[wp-trac] [WordPress Trac] #14911: Don't fetch theme_roots on every page load.
WordPress Trac
wp-trac at lists.automattic.com
Wed Oct 6 09:49:15 UTC 2010
#14911: Don't fetch theme_roots on every page load.
--------------------------+-------------------------------------------------
Reporter: ryan | Owner:
Type: defect (bug) | Status: reopened
Priority: normal | Milestone: 3.1
Component: Performance | Version:
Severity: normal | Resolution:
Keywords: has-patch |
--------------------------+-------------------------------------------------
Comment(by hakre):
Looks like this is breaking backwards compability.
Additionally I think the function should be named with the raw at the end
not after the get or according to what's written in the docblocks, to
get_theme_root_unfiltered(). raw is a pretty broad term which makes it
easy to misread.
Then I wonder why get_theme_root() calls get_raw_theme_root a.k.a.
get_theme_root_unfiltered() because both functions look to be for the same
thing (get theme root) but using a different approach (strategy: filtered
and unfiltered). but mixing both destroys the first and the second
strategy even with the cost of introducing a third one. That is making
things complicated. My 2 cents.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/14911#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list