[wp-trac] [WordPress Trac] #14999: Reject invalid theme.zip uploads

[WordPress Trac]

#14999: Reject invalid theme.zip uploads
-----------------------------+----------------------------------------------
 Reporter:  jstrebel         |       Owner:                 
     Type:  enhancement      |      Status:  new            
 Priority:  normal           |   Milestone:  Awaiting Review
Component:  Upgrade/Install  |     Version:                 
 Severity:  normal           |    Keywords:  theme upload   
-----------------------------+----------------------------------------------

Comment(by blepoxp):

 I looked at this briefly this morning and even tested it by zipping a file
 with no style.css in it (or other legit theme files for that matter).

 The zip is uploaded, unpacked, and moved to the theme folder. If all that
 works, the importer responds positively because it did upload, unpack, and
 move a folder to the themes directory as requested.

 If you then go look at the available themes, you will see the improperly
 documented theme at the bottom of the screen in the 'broken themes'
 sections. Also confirmed is that 'folder already exists' message when
 attempting to upload it again... but that makes since.

 If you didn't want to do verification at the point of unpacking the zip
 (this process takes place in the parent class BTW and not just the install
 themes extended class), we could possibly tack on an error message in the
 theme instal skin that identifies that folder as being broken along with a
 link as Joshua mentioned . We could possibly even provide a link to delete
 the folder...

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/14999#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software