[wp-trac] [WordPress Trac] #13699: File Header (Plugin Header, Theme Header) Improvement
WordPress Trac
wp-trac at lists.automattic.com
Tue Nov 23 19:45:54 UTC 2010
#13699: File Header (Plugin Header, Theme Header) Improvement
-----------------------------+----------------------------------------------
Reporter: hakre | Owner:
Type: feature request | Status: new
Priority: normal | Milestone: Awaiting Review
Component: General | Version: 3.0
Severity: normal | Keywords: has-patch dev-feedback
-----------------------------+----------------------------------------------
Comment(by hakre):
Patch has been refreshed against trunk. As said, the way how headers are
parsed are basically the same. I changed the regexes to reflect [16215].
In difference to the current parser, this one expects all headers to be
lined-up in one block (one after the other, one per line) and it actually
expects a header to have a value. In the current implementation this
differs, it looks for headers everywhere in the first 8KB of the file
(which turned out the error in #15193 most probably) and does not take
care if a header actually contains a value or not.
I've tested the 13699.step1-r2.patch against a multitude of plugins with
different formattings, and it looks good to me so far. But I have not run
it against a list of all plugins from the repository for example.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/13699#comment:12>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list