[wp-trac] [WordPress Trac] #14642: Support Facebook's HipHop

[WordPress Trac]

#14642: Support Facebook's HipHop
-------------------------+--------------------------------------------------
 Reporter:  ChenHui      |       Owner:  nacin                    
     Type:  enhancement  |      Status:  accepted                 
 Priority:  normal       |   Milestone:  3.1                      
Component:  Performance  |     Version:                           
 Severity:  normal       |    Keywords:  has-patch ongoing-project
-------------------------+--------------------------------------------------

Comment(by westi):

 Replying to [comment:14 nacin]:
 > The other array casts seem to be deficiencies in the HPHP engine.
 >
 >  - $qs will always be an array as it is used as the by reference
 argument for parse_str.
 >  - $r will always be an array, as it is either the result of
 get_object_vars(), $args within an is_array() check, or again parse_str.
 >  - $kayvees will always be an array as it is func_get_arg(0) within an
 is_array() check.
 >
 > I'd rather not add casts just to add casts, when these should be
 reported upstream I think.
 >
 > I'm just now seeing
 http://core.trac.wordpress.org/ticket/14642#comment:8 which explains that
 HPHP declines to extract the 'ID' key, hence why we need to kill EXTR_SKIP
 there specifically. I'm not convinced we should make our code more
 convoluted there for that one change. But, if it's the only thing to stop
 us from full support, then it could be considered.
 >

 This reads very much like a bug in HPHP that would affect a lot more than
 just us and could randomly affect other places extract is used too :-(

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/14642#comment:15>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software