[wp-trac] [WordPress Trac] #15321: Leading <li> missing from subsubsub menu items on plugin install page(s)

[WordPress Trac]

#15321: Leading <li> missing from subsubsub menu items on plugin install page(s)
---------------------------+------------------------------------------------
 Reporter:  deanjrobinson  |       Owner:                 
     Type:  defect (bug)   |      Status:  new            
 Priority:  normal         |   Milestone:  Awaiting Review
Component:  Validation     |     Version:  3.1            
 Severity:  normal         |    Keywords:                 
---------------------------+------------------------------------------------
 Leading <li> missing from subsubsub menu items on plugin install pages(s),
 looks like it might have been introduced in [15578] (the change to the
 class mentioned below likely happened before that though)

 Results in markup such as this:

 {{{
 <ul class='subsubsub'>
 <a href='http://localhost/trunk/wp-admin/plugin-install.php?tab=dashboard'
 class="current">Search</a> |</li>
 <a href='http://localhost/trunk/wp-admin/plugin-
 install.php?tab=upload'>Upload</a> |</li>
 <a href='http://localhost/trunk/wp-admin/plugin-
 install.php?tab=featured'>Featured</a> |</li>
 <a href='http://localhost/trunk/wp-admin/plugin-
 install.php?tab=popular'>Popular</a> |</li>
 <a href='http://localhost/trunk/wp-admin/plugin-
 install.php?tab=new'>Newest</a> |</li>
 <a href='http://localhost/trunk/wp-admin/plugin-
 install.php?tab=updated'>Recently Updated</a></li>
 </ul>
 }}}

 Bit hard to track down where/what/when exactly it changed since the class
 files seem to have shuffled around a lot in the last week or so, but it
 appears to be its caused due to the leading <li> not being added in the
 get_views() function in

 {{{
 /wp-admin/includes/class-wp-plugin-install-list-table.php
 }}}

 The leading <li> looks to be added as part of the get_views() function in
 the other class(es) such as class-wp-plugins-list-table.php and class-wp-
 posts-list-table.php

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/15321>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software