[wp-trac] [WordPress Trac] #13231: Refactoring of custom header page

WordPress Trac wp-trac at lists.automattic.com
Sun May 16 14:43:56 UTC 2010


#13231: Refactoring of custom header page
----------------------------+-----------------------------------------------
 Reporter:  ocean90         |       Owner:           
     Type:  enhancement     |      Status:  new      
 Priority:  normal          |   Milestone:  3.0      
Component:  Administration  |     Version:  3.0      
 Severity:  normal          |    Keywords:  has-patch
----------------------------+-----------------------------------------------

Comment(by ocean90):

 Thx for your comment.
   First, we should entirely scrap transparency. Way too close to release
 for that, it should be saved for 3.1.

 Because of that reason I created the ticket with the patch 13 days ago,
 but okay, I remove it and create a new ticket #13411.

   The image preview is cut off.
 Please check this again, it should work, see http://screenr.com/URp

   NO_HEADER_TEXT should probably be a true/false check
 Yup, I introduce ''header_text()'' for this check. true = show text, false
 = hide text.

   Remove the CDATA blocks
 No! It should be valid,otherwise it is not valid. Harke only want to
 improve them, see also azaozz comment.

   Overall, some very good improvements here. After saying it for a week, I
 would really like to check this in soon.

 Fine. Patch comes. :)

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/13231#comment:7>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list