[wp-trac] [WordPress Trac] #13317: Code Impriovement in get_userdata

WordPress Trac wp-trac at lists.automattic.com
Sat May 15 22:57:12 UTC 2010


#13317: Code Impriovement in get_userdata
------------------------------------+---------------------------------------
 Reporter:  hakre                   |        Owner:          
     Type:  defect (bug)            |       Status:  reopened
 Priority:  high                    |    Milestone:  3.0     
Component:  Security                |      Version:          
 Severity:  major                   |   Resolution:          
 Keywords:  has-patch dev-feedback  |  
------------------------------------+---------------------------------------

Comment(by hakre):

 Replying to [comment:17 nacin]:
 You should not concentrate too much why to not make a change but why. In
 this case (and be lucky it got noticed) this function should not return
 the admin user object on error. so, you do not need to run all core up and
 down and insert checks, but just in places where it can actually make
 sense.

 Any way, I'll add a patch for that one and for the general replacement of
 the absint() calls.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/13317#comment:18>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list