[wp-trac] [WordPress Trac] #14141: Parameter usage in edit_bookmark_link

[WordPress Trac]

#14141: Parameter usage in edit_bookmark_link
--------------------------+-------------------------------------------------
 Reporter:  linguasite    |       Owner:                          
     Type:  defect (bug)  |      Status:  new                     
 Priority:  normal        |   Milestone:  Awaiting Review         
Component:  Template      |     Version:  3.0                     
 Severity:  normal        |    Keywords:  link, bookmark, template
--------------------------+-------------------------------------------------
 The function edit_bookmark_link in /wp_includes/link-template.php accepts
 the following parameters:

 {{{
 edit_bookmark_link( $link = '', $before = '', $after = '', $bookmark =
 null )
 }}}

 Internally, the first parameter $link is used as the link_id:
 Line 957:
 {{{
 $link = '<a href="' . get_edit_bookmark_link( $link ) . '" title="' . __(
 'Edit Link' ) . '">' . $link . '</a>';
 }}}

 As I understand the function, this parameter should be the link text. As a
 result, the only way to use this function is to provide the link_id as the
 first paramter and get the link_id as link text in the output.

 This version should work better:

 Line 957:
 {{{
 $link = '<a href="' . get_edit_bookmark_link( $bookmark ) . '" title="' .
 __( 'Edit Link' ) . '">' . $link . '</a>';
 }}}

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/14141>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software