[wp-trac] [WordPress Trac] #14127: Dashboard feed widgets should open entries in new tabs

WordPress Trac wp-trac at lists.automattic.com
Tue Jun 29 01:45:35 UTC 2010


#14127: Dashboard feed widgets should open entries in new tabs
-------------------------+--------------------------------------------------
 Reporter:  IndigoJo     |        Owner:            
     Type:  enhancement  |       Status:  closed    
 Priority:  normal       |    Milestone:            
Component:  General      |      Version:  3.0       
 Severity:  normal       |   Resolution:  worksforme
 Keywords:               |  
-------------------------+--------------------------------------------------

Comment(by filosofo):

 scribu's right: there's no reason to make a general penalty for users so
 long as you have the scroll click available.

 ----


 {{{
         if ( undefined == url )
                 return;
 }}}

 What does that get you that `if ( ! url )` doesn't?

 {{{
     if ( 0 != url.indexOf(location.protocol + '//' + location.host) ) {
                 window.open(url);
                 return false;
         }
 }}}

 The problem is that in the WP admin, the internal links are not absolute,
 so you'll be opening them in new windows too.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/14127#comment:3>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list