[wp-trac] [WordPress Trac] #13822: Menu items that get unpublished still appear

[WordPress Trac]

#13822: Menu items that get unpublished still appear
------------------------------------------------+---------------------------
 Reporter:  nacin                               |        Owner:  nacin    
     Type:  defect (bug)                        |       Status:  reviewing
 Priority:  highest omg bbq                     |    Milestone:  3.0      
Component:  Menus                               |      Version:  3.0      
 Severity:  major                               |   Resolution:           
 Keywords:  has-patch dev-feedback i18n-change  |  
------------------------------------------------+---------------------------

Comment(by koopersmith):

 {{{13822.merged.diff}}} merges filosofo's approach with the UX changes in
 nacin/my earlier patch. The following describes the UX changes and the
 reasoning behind their implementation.

 '''Menu item titles now reflect their object's status.'''

 Instead of reading "My Post (Draft)" for all non-published objects, titles
 now include their object's status, such as "My Post (Private)".

 This improves UX by informing the user ''why'' their post will not appear
 in the menu (and as a result, what they can change to have the menu item
 appear). This is especially useful for scheduled posts, as it reflects the
 fact that the menu will dynamically update.

 '''Trash behavior changes: On trash, make the menu item 'draft' instead of
 'pending'.'''

 The existing behavior is as follows:

  * Add post A to the menu. Save. Trash post A.
  * The menu item disappears from the frontend menu (as it should).
  * If post A is untrashed and the menu has not been edited, the menu item
 will be automatically restored to its original position.

 However, we run into trouble when we edit the menu:

  * Post A appears as "Post A (Pending)". You can edit this menu item like
 you would any other menu item. There's even a yellow box that reads "Click
 Save Menu to make pending menu items public."
  * When you save the menu, you are simultaneously presented with a warning
 that "Post A" referred to a trashed item and could not be saved, and a
 notice that the menu has been updated. The trashed item has been removed.

 There is no indication that the trashed item will be removed and no way
 for the user to recover the menu item. The fact that the item is labelled
 as "pending" only adds to the confusion.

 A menu item linking to a trashed post is no different than a menu item
 linking to a draft post or a pending post. If a menu item is untrashed it
 should reappear in the frontend menu (much like a menu item linking to a
 private post would if made public).

 In the backend, the item will now appear as "Post A (Trash)". If a user
 wants to delete the item, they will. If the user wants to rearrange the
 menu and untrash the post, they can do that too. We should not be making
 the decision to delete the menu item for them; we should be providing the
 information necessary for them to make a competent decision.

 (The implementation involved removing the trash/untrash listeners as well
 as the clause that deleted any menu items with trashed objects when the
 menu was saved.)

 '''Improve "Original: Link to post" box.'''

 Finally, the "Original: Link to post" has been updated to reflect any non-
 published post status (such as "Original: Link to post (Draft)"). Linking
 to a trashed post would lead to a 404—instead, we link to the appropriate
 trash page.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/13822#comment:18>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software