[wp-trac] [WordPress Trac] #13751: Unable to filter title tag on 404 pages in TwentyTen.
WordPress Trac
wp-trac at lists.automattic.com
Thu Jun 10 06:26:50 UTC 2010
#13751: Unable to filter title tag on 404 pages in TwentyTen.
--------------------------+-------------------------------------------------
Reporter: mfields | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 3.0
Component: Themes | Version: 3.0
Severity: normal | Keywords: has-patch commit
--------------------------+-------------------------------------------------
Comment(by nacin):
Went a different route entirely. Patch now hooks into wp_title()'s filter
instead. Sad ugly code to address the weakness of one of our functions now
looks like happy poetic code... to address the weakness of one of our
functions. :-)
As an added benefit, we're now adding page numbers to paged singular views
(we were previously only checking the $paged global, but we need to check
the $page global sometimes).
Quite happy with this result. This is backwards compatible for child
themes in that it won't break them, though twentyten_the_page_number() is
now gone so any overrides of that is now useless. But it's more friendly
for child themes now.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/13751#comment:3>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list