[wp-trac] [WordPress Trac] #7993: Missing tabindex argument for wp_dropdown generated inputs

WordPress Trac wp-trac at lists.automattic.com
Fri Jul 9 13:14:48 UTC 2010


#7993: Missing tabindex argument for wp_dropdown generated inputs
-------------------------+--------------------------------------------------
 Reporter:  Malaiac      |       Owner:  anonymous               
     Type:  enhancement  |      Status:  new                     
 Priority:  normal       |   Milestone:  Future Release          
Component:  Template     |     Version:  2.7                     
 Severity:  minor        |    Keywords:  usability gsoc has-patch
-------------------------+--------------------------------------------------

Comment(by nacin):

 I don't have a problem with adding it, only I wanted to clarify that it is
 not a usability issue as originally stated.

 Re: the patch, it doesn't look like it is properly sanitized.. The cast
 would only affect the comparison. Ideally it should default to false. If
 !== false, then absint() and use it. (0 is allowed as a tabindex value.)

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/7993#comment:6>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list