[wp-trac] [WordPress Trac] #14243: Content of css interfering with functions

[WordPress Trac]

#14243: Content of css interfering with functions
--------------------------+-------------------------------------------------
 Reporter:  matveb        |       Owner:                        
     Type:  defect (bug)  |      Status:  new                   
 Priority:  lowest        |   Milestone:  Awaiting Review       
Component:  Themes        |     Version:                        
 Severity:  minor         |    Keywords:  has-patch dev-feedback
--------------------------+-------------------------------------------------
Changes (by nkuttler):

  * keywords:  has-patch => has-patch dev-feedback


Comment:

 The patch works fine for me. The get_file_data() code is normally only run
 in the admin and on theme CSS and plugin PHP files. So a performance hit
 doesn't seem relevant. The tokenizer seems to work fine and has been
 included in PHP since 4.3
 (http://www.php.net/manual/en/tokenizer.installation.php) which is the
 minimum requirement for WordPress.

 If there is concern that people depart from the documented way of writing
 plugin meta info
 (http://codex.wordpress.org/Writing_a_Plugin#File_Headers) a flag could be
 added to the get_file_data() call to differentiate between the parsing of
 PHP and CSS files. This way meta data in

 # foo and

 // bar

 type comments could be taken care of as well.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/14243#comment:8>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software