[wp-trac] [WordPress Trac] #14184: empty() and "0" in class-http.php

[WordPress Trac]

#14184: empty() and "0" in class-http.php
--------------------------+-------------------------------------------------
 Reporter:  mailnew2ster  |       Owner:                         
     Type:  defect (bug)  |      Status:  new                    
 Priority:  normal        |   Milestone:  Awaiting Review        
Component:  HTTP          |     Version:                         
 Severity:  normal        |    Keywords:  has-patch needs-testing
--------------------------+-------------------------------------------------

Comment(by jacobsantos):

 * Line 243: Not required, empty is not only checking for the string is
 empty, but also for null, 0, etc. The next empty is making not only sure
 that the URL is "valid" but also that there is a scheme part of the URL.
  * Line 282: Again, $r['body'] might be null, 0, false, so not change.
  * Line 428: Seriously, not everything is a string comparison. No change.
  * Line 437: No change required.
  * Line 447: Fixes original ticket, probably needed.
  * Line 515: Actually, for the Chunked Decode, every resource and test has
 reliably came up with '0' as the end of the chunks and not '00', so no
 modification required.
  * Line 697: Meh, either way is fine.
  * Line 758: If it isn't broke, don't 'fix' it.

 There are more, but these are the ones I see so far.
  * Line 1037: Same as line 282, the empty check is required.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/14184#comment:3>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software