[wp-trac] [WordPress Trac] #11881: setup-config.php step 2 broken
WordPress Trac
wp-trac at lists.automattic.com
Wed Jan 27 22:00:13 UTC 2010
#11881: setup-config.php step 2 broken
-----------------------------+----------------------------------------------
Reporter: sivel | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 3.0
Component: Upgrade/Install | Version: 3.0
Severity: major | Keywords: has-patch multisite
-----------------------------+----------------------------------------------
Changes (by nacin):
* keywords: has-patch => has-patch multisite
Comment:
[attachment:11881.10.diff] rearranges the multisite initialization files.
More or less, ms-settings.php and ms-load.php have swapped large amounts
of code. ms-load.php now mirrors load.php, in that it only contains
functions required for/during initialization. ms-settings.php is now
included in wp-settings.php (instead of ms-load.php) and includes ms-
load.php and ms-default-constants.php.
ms-settings.php contains no functions and, as you can imagine, now mirrors
wp-settings.php.
ms-default-constants.php also ate up ms_network_cookies() (I suppose pun
intended).
This is ready for review and commit. Ideally we could then spin off some
code in ms-settings.php into functions in ms-load.php, the same way we
split up wp-settings.php in this ticket.
I know westi indicated he wanted to refactor wp_default_constants() at
some point; the same would apply to ms_default_constants() as well.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/11881#comment:40>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list