[wp-trac] [WordPress Trac] #11796: Deprecate VHOSTS in favor of a boolean

WordPress Trac wp-trac at lists.automattic.com
Tue Jan 26 08:46:40 UTC 2010


#11796: Deprecate VHOSTS in favor of a boolean
-------------------------------+--------------------------------------------
 Reporter:  Denis-de-Bernardy  |        Owner:          
     Type:  enhancement        |       Status:  reopened
 Priority:  normal             |    Milestone:  3.0     
Component:  Multisite          |      Version:  3.0     
 Severity:  normal             |   Resolution:          
 Keywords:  has-patch          |  
-------------------------------+--------------------------------------------

Comment(by nacin):

 As an MU administrator I am fully prepared for my blog to break on the
 next upgrade, but you're right.

 The more I think about this, I think we should deprecate the VHOST
 constant all together. We'll create a new boolean SUBDOMAIN_INSTALL
 constant and encourage use of the API, is_subdomain_install().

 If VHOST is defined, we'll throw a deprecated warning and inform them of
 SUBDOMAIN_INSTALL and is_subdomain_install(). We'll also define VHOST for
 back compat when we're using the new constant. If both is defined for some
 reason, we'll use SUBDOMAIN_INSTALL and throw a deprecated warning, unless
 of course they are set to different things, in which case we pick
 SUBDOMAIN_INSTALL and throw a louder error.

 Not only does this get us away from yes/no to a bool, it also will
 encourage very quickly the use of is_subdomain_install().

 Let me put together a patch.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/11796#comment:9>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list