[wp-trac] [WordPress Trac] #11643: Invalid code in wp-login.php

[WordPress Trac]

#11643: Invalid  code in wp-login.php
-------------------------------------+--------------------------------------
 Reporter:  hakre                    |        Owner:        
     Type:  defect (bug)             |       Status:  closed
 Priority:  normal                   |    Milestone:  3.0   
Component:  General                  |      Version:  2.9   
 Severity:  normal                   |   Resolution:  fixed 
 Keywords:  has-patch needs-testing  |  
-------------------------------------+--------------------------------------

Comment(by dd32):

 That doesnt really explain the line anymore...

 {{{
 if ( var is false &....
  then set var to false
 }}}

 It'll never be run if $secure_cookie is true, or for that matter, anything
 non-null/non-false/non-empty.

 If $secure_cookie is true, Then none of the rest will be run, and it'll
 never be set to false. If $secure_cookie is false, then it may get set to
 false again.

 I can see what the logic is intending, I just dont see how it can ever
 work with !$secure_cookie at the start.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/11643#comment:7>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software