[wp-trac] [WordPress Trac] #11588: show_message() should flush the output buffers when its called.

WordPress Trac wp-trac at lists.automattic.com
Tue Jan 5 17:43:48 UTC 2010


#11588: show_message() should flush the output buffers when its called.
-----------------------------+----------------------------------------------
 Reporter:  dd32             |       Owner:                        
     Type:  feature request  |      Status:  new                   
 Priority:  normal           |   Milestone:  3.0                   
Component:  Administration   |     Version:  2.9                   
 Severity:  normal           |    Keywords:  has-patch dev-feedback
-----------------------------+----------------------------------------------

Comment(by nacin):

 show_message() is specifically for the upgraders. Upgrading can take a
 while, and we deliberately call show_message() to write information to the
 browser updating the user on the status of the upgrades, as the package is
 downloaded, unpacked, etc.

 From what I have gathered from dd32, the original intention of
 show_message() was to send output to the browser. Not including a flush()
 here was an accidental omission when the upgraders were written.

 Hence why we should flush here even though we don't anywhere else in core.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/11588#comment:12>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list