[wp-trac] [WordPress Trac] #11329: Allow _wp_get_comment_list() to return comments only for specific users

WordPress Trac wp-trac at lists.automattic.com
Fri Feb 26 15:15:32 UTC 2010


#11329: Allow _wp_get_comment_list() to return comments only for specific users
----------------------------+-----------------------------------------------
 Reporter:  pampfelimetten  |       Owner:  Denis-de-Bernardy
     Type:  enhancement     |      Status:  reviewing        
 Priority:  normal          |   Milestone:  3.0              
Component:  Query           |     Version:  2.8.5            
 Severity:  normal          |    Keywords:  needs-patch      
----------------------------+-----------------------------------------------
Changes (by nacin):

  * keywords:  dev-feedback tested => needs-patch


Comment:

 The patch needs some improvement as it stands. At the very least, we
 should absint() the user id, and for when it is an array, array_map() on
 absint(). The query thus should not quote user ids in SQL, as they are of
 the numeric type. The filter should be false by default, instead of a
 string, as it doesn't expect a string -- it expects an user ID (integer)
 or array of integers.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/11329#comment:14>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list