[wp-trac] [WordPress Trac] #10555: number_format_i18n function doesn't check if the number is float or not before doing the formating

WordPress Trac wp-trac at lists.automattic.com
Tue Feb 23 14:20:11 UTC 2010


#10555: number_format_i18n function doesn't check if the number is float or not
before doing the formating
--------------------------+-------------------------------------------------
 Reporter:  chombium      |       Owner:  nbachiyski                   
     Type:  defect (bug)  |      Status:  new                          
 Priority:  normal        |   Milestone:  3.0                          
Component:  i18n          |     Version:  2.9                          
 Severity:  normal        |    Keywords:  has-patch needs-testing early
--------------------------+-------------------------------------------------

Comment(by nbachiyski):

 Everywhere in WordPress number_format_i18n is used for integers only. The
 simplest solution is to make it work only with integers and deprecate all
 the decimals stuff. If at any point we need the floating point behaviour,
 we can always put the functionality back.

 My patch deprecates the decimal arguments for number_format_i18n and
 size_format and locale-specific decimals and decimal point settings.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/10555#comment:8>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list