[wp-trac] [WordPress Trac] #11644: multiple blogs & sites / merge WPMU

[WordPress Trac]

#11644: multiple blogs & sites / merge WPMU
----------------------------+-----------------------------------------------
 Reporter:  hakre           |       Owner:  wpmuguru 
     Type:  task (blessed)  |      Status:  assigned 
 Priority:  normal          |   Milestone:  3.0      
Component:  Multisite       |     Version:           
 Severity:  normal          |    Keywords:  multisite
----------------------------+-----------------------------------------------

Comment(by hakre):

 Next iteration, Issues I see so far:

  1. UNFIXED {{{__destruct()}}} breaks with PHP5 defition of the return
 value (should be void, is true)
  2. UNFIXED $blog_id sometimes is int, then it's string
  3. UNFIXED: Some functions have parameters documented which are not
 implemented {{{$dbh_or_table}}}. Comments should be removed.
  4. wpdb::old_tables is not deprecated
  5. comment parameter variable names do not end with a . ({{{* @param int
 $blog_id. Optional.}}})
  6. Diverse whitespace (as always).
  7. Variables start with a $ even if they are class members - even in
 documentation ({{{@uses wpdb::tables}}} -> {{{@uses wpdb::$tables}}})
  8. In wpdb::tables(): function parameter $prefix should not be
 overwritten with blog-prefix.
  9. In wpdb::tables(): to replace an entry, first unset then set - not the
 other way round ({{{unset( $tables[ $k ] );}}})
  10. In wpdb::tables(): added {{{'blog+old'}}} scope
  11. In wpdb::tables(): scope values inside docblock and not inside the
 parameter description.
  12. In wpdb::tables(): first parameter can be overloaded with array
  13. Additional code exmaple in wpdb::prepare() that demonstrates %%
 usage. (Related: #11318)
  14. Reduced code complexity in wpdb::print_error()
  15. die() replaced with wp_die in wpdb::print_error() (Related: #11892)
  16. Some inline comments which were obviously not necressary (reading the
 code says more than reading the comment) were removed.
  17. Additional code example in  wpdb::insert() and wpdb::update()
 docblock
  18. Streamlined optional parameter comments. Change made from (optional)
 to Optional.
  19. Uppercase of contants (NULL, FALSE) in certain docblocks.
  20. Refactoring of wpdb::get_caller(): Reduced complexity.


 Further suggestions:

  14. OPEN: Sort all the table variable names alphabetically and put them
 after each other in code. Put all three tables array variables next to
 each other as well.
  15. OPEN: Research of version numbers for certain members

 Regarding 12.): If that (array overloading) is of no use for plugins and
 scope {{{'blog+old'}}} get's in, I suggest to drop that idea.

 Regarding further suggestions: I collected some stuff that might make
 sense to fix when the more current issues are committed / dropped to
 further reduce code-fuzz. 13.) will just take some time, but it's on my
 list.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/11644#comment:191>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software