[wp-trac] [WordPress Trac] #11914: "Users" admin list slow to generate on large sites

[WordPress Trac]

#11914: "Users" admin list slow to generate on large sites
--------------------------+-------------------------------------------------
 Reporter:  rowanbeentje  |       Owner:                         
     Type:  defect (bug)  |      Status:  new                    
 Priority:  high          |   Milestone:  3.0                    
Component:  Optimization  |     Version:  2.9.1                  
 Severity:  critical      |    Keywords:  has-patch needs-testing
--------------------------+-------------------------------------------------

Comment(by miqrogroove):

 Replying to [comment:29 ryan]:

 Thanks for the great feedback.  :)

 > Does the call to user_row() in admin-ajax.php need to change to
 accommodate the new arg?

 My understanding is admin-ajax only calls user_row() for new user
 creation, and the new arg has an appropriate default.  It's future-proof
 in the sense that any new behavior in admin-ajax should be able to use
 that arg when necessary.

 > cache_users() doesn't cache user meta. I think meta is expected to be
 cached as in _fill_user().
 >
 > cache_users() could be called update_user_caches() to fit in with
 update_post_caches() and other.

 Okay, I will research that some more.

 > Maybe the existing get_usernumposts() func could be called
 count_users_posts() to bring it in line with other count funcs and call
 get_users_numposts() something like count_all_users_posts().

 Is there a concern about breaking plugins with that?  Should I add an
 alias function too?

 > And maybe give count_blog_users_by_role_inmem() and
 count_blog_users_by_role_intime() less unwieldy names. count_users() with
 some args?

 The overall intention was to present two separate strategies I worked on,
 and ultimately dump the _inmem version unless it is valuable to keep it in
 the API.  count_users() with both strategies under one roof is fine with
 me.  :)

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/11914#comment:30>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software