[wp-trac] [WordPress Trac] #12278: 3 year old bugs in wp-admin file uploading

WordPress Trac wp-trac at lists.automattic.com
Thu Feb 18 19:21:22 UTC 2010


#12278: 3 year old bugs in wp-admin file uploading
--------------------------+-------------------------------------------------
 Reporter:  tychay        |       Owner:             
     Type:  defect (bug)  |      Status:  new        
 Priority:  normal        |   Milestone:  Unassigned 
Component:  Upload        |     Version:  2.9.2      
 Severity:  minor         |    Keywords:  file upload
--------------------------+-------------------------------------------------
 They're relatively minor:

 - in media.php, $overrides was supposed to be a passable parameter (so it
 can be sent upstream to file.php) but Andy forgot to put it in.

 - in file.php, there are a number of $$ calls where call_user_func is more
 appropriate (after all, you can overrides with a object->method call, but
 that will break $$).

 - there is another bug in file.php where if it errors out before extract
 the wrong error handler may be called (if overridden). I DID NOT PATCH
 THIS, but I made a note of it int he comments.

 Two patch files are attached

 WordPress.com reference:
 https://wpcom.automattic.com/changeset/22464
 https://wpcom.automattic.com/changeset/22365

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/12278>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list