[wp-trac] [WordPress Trac] #12089: Unintended blank lines in plugins break XML for feeds
WordPress Trac
wp-trac at lists.automattic.com
Mon Feb 15 16:02:35 UTC 2010
#12089: Unintended blank lines in plugins break XML for feeds
--------------------------+-------------------------------------------------
Reporter: bchecketts | Owner:
Type: defect (bug) | Status: new
Priority: low | Milestone: 3.0
Component: Feeds | Version:
Severity: normal | Keywords:
--------------------------+-------------------------------------------------
Comment(by miqrogroove):
Maybe we're not on the same page yet. I'm thinking of heres-my-bad-
plugin.php:
{{{
<?php
/** Plugin-Author: Me. **/
add_action('blah', 'phpinfo');
?>
oops there's stuff here
}}}
In activate_plugin, there's a buffer that's used to block non-fatal
errors. If the buffer survives, it gets deleted and the plugin is
activated. I'm proposing a fix so that the buffer is examined, and if
it's not empty for any reason, it should get reported the same way as the
fatal errors. The buffer could say "oops there's stuff here", or it could
just as easily say, "Warning: blah not defined, assuming 'blah'". Prefix
that with something informative like, "This plugin generated the following
unexpected output:"
--
Ticket URL: <http://core.trac.wordpress.org/ticket/12089#comment:7>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list