[wp-trac] [WordPress Trac] #12159: Define random keys and salts during setup-config.php
WordPress Trac
wp-trac at lists.automattic.com
Sun Feb 14 16:18:53 UTC 2010
#12159: Define random keys and salts during setup-config.php
-------------------------+--------------------------------------------------
Reporter: nacin | Owner: ryan
Type: enhancement | Status: new
Priority: normal | Milestone: 3.0
Component: Security | Version:
Severity: normal | Keywords:
-------------------------+--------------------------------------------------
Comment(by sivel):
Ok, not sure what happened there...
Replying to [comment:19 aaroncampbell]:
> Regarding [13137], the parameters on wp_generate_password seem to work
awkwardly. It seems that if you have two separate parameters for special
characters and extra special characters, then you should be able to pass
something like `(12, false, true)` and have it use standard and extra
special, but not special (which it doesn't do). Alternatively, if the
function should continue to work as it does, maybe we could remove the
third parameter and let you pass something to specify a set of characters
(Something like: 0 for standard, 1 for extended, 2 for all).
>
> If we think one of these options should be used, let me know and I'll
throw together a patch to apply.
I see what you are saying, my original intention was to only allow
$extra_special_chars if you were using $special_chars. Since that does
seem a little akward, without context to the arguments, I would just move
the $extra_special_chars out of the if for $special_chars.
Since it was an very easy change patch coming in a second.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/12159#comment:21>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list