[wp-trac] [WordPress Trac] #9015: New theme for 3.0 -- Twenty Ten
WordPress Trac
wp-trac at lists.automattic.com
Fri Feb 12 09:06:27 UTC 2010
#9015: New theme for 3.0 -- Twenty Ten
----------------------------+-----------------------------------------------
Reporter: dd32 | Owner:
Type: task (blessed) | Status: new
Priority: normal | Milestone: 3.0
Component: Themes | Version:
Severity: normal | Keywords:
----------------------------+-----------------------------------------------
Comment(by ptahdunbar):
Replying to [comment:64 nacin]:
> Replying to [comment:58 ptahdunbar]:
> > Style.css aside, what are your thoughts on the twentyten-clean-
up.patch?
>
> I'm thinking that very large patches (I'm guilty of this sometimes too)
in this case are difficult to follow and go stale quickly (it may be stale
already).
>
> It also makes it more difficult to see issues with the patch. For
example, at one point you change {{{||}}} to {{{OR}}}, which are not
interchangeable.
>
> At least in my opinion, smaller patches would allow for better review.
It all started out with prefixing the functions with twentyten_, then I
saw a lot of other little things that needed translation, then I started
making small enhancements and making the code more extendable and
efficient... and yeah, it was a snowball effect ;D
I figured bundling up all the changes together instead of uploading fifty
million patches which are all about doing the same thing would be better.
But I'd keep in mind to do smaller patches in the future. If you want,
I'll start to separate the patch out into smaller ones if that helps?
--
Ticket URL: <http://core.trac.wordpress.org/ticket/9015#comment:65>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list