[wp-trac] [WordPress Trac] #10910: Standardize comment form

[WordPress Trac]

#10910: Standardize comment form
----------------------------+-----------------------------------------------
 Reporter:  Otto42          |       Owner:  beaulebens
     Type:  task (blessed)  |      Status:  assigned  
 Priority:  normal          |   Milestone:  3.0       
Component:  Comments        |     Version:  2.9       
 Severity:  normal          |    Keywords:  has-patch 
----------------------------+-----------------------------------------------

Comment(by Otto42):

 Replying to [comment:33 greenshady]:
 >
 > I didn't introduce those classes and IDs.  I just used the ones already
 committed.

 I wasn't blaming anybody in particular. Just saying how wrong they are. :)

 The ID's are wholly unnecessary. Classes are enough. You'd only need IDs
 if you're going to have more than one comment form on the page.

 "form-section" and "form-label"? Come on. How generic can you get? The
 names of these things are supposed to be descriptive. If I wanted to
 address all the labels in forms using CSS, then there's a perfectly good
 way to do that: form label { whatever:xx; } Merely reproducing HTML in
 class-names is bloody stupid.

 You really do need a wrapper around the fields. What if I want to hide the
 fields after an alternative login mechanism (Facebook, for example)?
 comment_form_before_fields and comment_form_after_fields are find for
 this, all you need is a div wrapper.

 The 2010 theme as a whole has these same basic problems in several places,
 but those are better expressed in other tickets.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/10910#comment:34>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software