[wp-trac] [WordPress Trac] #16046: do_action(quick_edit_custom_box) results in duplicates

WordPress Trac wp-trac at lists.automattic.com
Fri Dec 31 03:37:24 UTC 2010


#16046: do_action(quick_edit_custom_box) results in duplicates
-----------------------------+-----------------------
 Reporter:  nerrad           |       Owner:
     Type:  defect (bug)     |      Status:  reopened
 Priority:  normal           |   Milestone:  3.1
Component:  Quick/Bulk Edit  |     Version:  3.1
 Severity:  normal           |  Resolution:
 Keywords:                   |
-----------------------------+-----------------------
Changes (by nacin):

 * status:  closed => reopened
 * resolution:  invalid =>
 * milestone:  Awaiting Review => 3.1


Comment:

 I see a regression. I'm not sure why this change was made.

 In 3.0, inline_edit_term_row() took $type ('edit-tags', 'categories', or
 'edit-link-categories') and $taxonomy.

 In 3.0 we didn't account for the merger of 'edit-tags' and 'categories'.
 It appears people didn't rely on this argument as we hadn't seen a report.
 That's fine with me.

 But, the taxonomy argument has now moved. That's a problem for people
 adding custom column data here.

 We should just pass 'edit-tags' consistently and bump the argument down
 one. This is also helpful to distinguish between post type and taxonomy
 usage of the filter.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16046#comment:3>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list