[wp-trac] [WordPress Trac] #15855: Dropdown isn't shown when doing a user 'removal'

[WordPress Trac]

#15855: Dropdown isn't shown when doing a user 'removal'
--------------------------+------------------
 Reporter:  scribu        |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  3.1
Component:  Multisite     |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+------------------

Comment (by westi):

 Replying to [comment:18 SergeyBiryukov]:
 > Replying to [comment:16 westi]:
 > > A shared function for the shared code maybe but this doesn't sit well
 in it's current state for me.
 > How can it be improved?

 Doing this {{{switch ( $action ) {}}} three times in the same function
 makes it really hard to ensure that any changes made in the future are
 done correctly.

 I would make a shared function for the dropdown generation code and move
 the rest of the code back into wp-admin/users.php in the two different
 cases where your new function is called with the different actions.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/15855#comment:19>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software