[wp-trac] [WordPress Trac] #15920: List table screens in network admin break if no item is selected for bulk actions

[WordPress Trac]

#15920: List table screens in network admin break if no item is selected for bulk
actions
-------------------------------------+-----------------------
 Reporter:  PeteMall                 |       Owner:  PeteMall
     Type:  defect (bug)             |      Status:  accepted
 Priority:  normal                   |   Milestone:  3.1
Component:  General                  |     Version:  3.1
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |
-------------------------------------+-----------------------

Comment (by nacin):

 New patch:

  - Removes apparently bogus esc_html() wrappers around
 `$theme['Stylesheet']` in WP_MS_Themes_List_Table. This is the directory
 name so it should be pretty safe already, and every usage of it ends up in
 esc_url() or esc_attr(). If for some reason `esc_html( $theme_key ) !=
 $theme_key` though, this would pose quite a number of problems, as the
 database would be improperly updated.

  - Hides the 'Delete' link for a theme active on the main site.

  - Prevents theme deletion for a theme active on the main site.

  - Properly resets the request URI arguments.

  - Switches to more direct `enabled=N` (etc) messages. Also doesn't show
 "1" in the string when only one theme is deleted.

 I'm still not a fan of this direct-to-DB logic, but I'll let ryan weigh in
 on the necessity of reworking that into a saner check.
 {{{
                         $allowed_themes[ $_GET['theme'] ] = true;
                         update_site_option( 'allowedthemes',
 $allowed_themes );
 }}}

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/15920#comment:11>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software