[wp-trac] [WordPress Trac] #13651: Problem with plural form in comments_number

[WordPress Trac]

#13651: Problem with plural form in comments_number
-----------------------------+-------------------------
 Reporter:  pavelevap        |       Owner:  nbachiyski
     Type:  defect (bug)     |      Status:  new
 Priority:  highest omg bbq  |   Milestone:  3.1
Component:  I18N             |     Version:  3.0
 Severity:  major            |  Resolution:
 Keywords:                   |
-----------------------------+-------------------------

Comment (by nbachiyski):

 Replying to [comment:27 westi]:
 >  * _get_comments_number_translated_format should probably just be part
 of _get_comments_number_text_helper as it is only ever called from there
 as far as I can tell

 It used to be used in another place. Why do you think it should be in the
 other functions? It does something specific and two short functions are
 easier to read than one bigger.

 >  * I'm not a big fan of deprecating comments_number and
 comments_popup_link without trying to make them use the new functions if
 possible?

 I left them like this, exactly to prevent subtle changes of current
 functionality this late in the cycle. Apart from that I agree we should
 make them use the new ones.

 Also, we should probably not deprecate them for now. Just introduce the
 new ones and use them in 2010. As you said, it's pretty late in the cycle.

 >  * Need full phpdoc on the new functions

 Yes, I am on it.

 >  * Not sure of the point of double apply_filters calls when they don't
 provide different contexts.

 Because usually these filters match the function name. In the
 documentation only {{{comments_number_text}}} will be advertised, but the
 old one should work too, for backwards compatibility.

 >  * get_comments_number_link code for post_password_required is broken.

 What do you mean by broken? WFM.

 It had an extra if-clause, which I fixed in the second patch.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/13651#comment:28>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software