[wp-trac] [WordPress Trac] #13651: Problem with plural form in comments_number

[WordPress Trac]

#13651: Problem with plural form in comments_number
-----------------------------+-------------------------
 Reporter:  pavelevap        |       Owner:  nbachiyski
     Type:  defect (bug)     |      Status:  new
 Priority:  highest omg bbq  |   Milestone:  3.1
Component:  I18N             |     Version:  3.0
 Severity:  major            |  Resolution:
 Keywords:                   |
-----------------------------+-------------------------

Comment (by westi):

 Replying to [comment:26 nbachiyski]:
 > All the POT-generating infrastructure is in place and running.
 >
 > Any other objections/comments before committing it?

 I assume you are referring to comments-number-i18n-custom-parsing.diff

 I'm a little wary of reworking this code so close to release - I
 understand the desire to support the translation here better but I'm not
 sure this is the right point in the cycle to make these changes.

 Other feedback:

  * _get_comments_number_translated_format should probably just be part of
 _get_comments_number_text_helper as it is only ever called from there as
 far as I can tell
  * I'm not a big fan of deprecating comments_number and
 comments_popup_link without trying to make them use the new functions if
 possible?
  * Need full phpdoc on the new functions
  * Not sure of the point of double apply_filters calls when they don't
 provide different contexts.
  * get_comments_number_link code for post_password_required is broken.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/13651#comment:27>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software