[wp-trac] [WordPress Trac] #13651: Problem with plural form in comments_number

WordPress Trac wp-trac at lists.automattic.com
Mon Dec 20 03:42:28 UTC 2010


#13651: Problem with plural form in comments_number
-----------------------------+-------------------------
 Reporter:  pavelevap        |       Owner:  nbachiyski
     Type:  defect (bug)     |      Status:  new
 Priority:  highest omg bbq  |   Milestone:  3.1
Component:  I18N             |     Version:  3.0
 Severity:  major            |  Resolution:
 Keywords:                   |
-----------------------------+-------------------------

Comment (by SergeyBiryukov):

 I'd like to suggest an approach based on Nikolay's first patch which seems
 more intuitive to me:
 * Doesn't require changes to `_n_noop()` or POT generation.
 * Keeps the usual logic of using domains only for i18n functions.
 * Therefore works with Poedit when updating from sources.

 The similar string is used in comments.php, which I consider as a valid
 example:
 {{{
 <h3 id="comments-title"><?php
 printf( _n( 'One Response to %2$s', '%1$s Responses to %2$s',
 get_comments_number(), 'twentyten' ),
 number_format_i18n( get_comments_number() ), '<em>' . get_the_title() .
 '</em>' );
 ?></h3>
 }}}

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/13651#comment:21>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list