[wp-trac] [WordPress Trac] #15287: Invalid markup in administration pages
WordPress Trac
wp-trac at lists.automattic.com
Sun Dec 19 06:12:41 UTC 2010
#15287: Invalid markup in administration pages
--------------------------+------------------
Reporter: wahgnube | Owner:
Type: defect (bug) | Status: new
Priority: low | Milestone: 3.1
Component: Validation | Version: 3.1
Severity: normal | Resolution:
Keywords: needs-patch |
--------------------------+------------------
Comment (by nacin):
In the case of the wp-admin/edit-comments.php diff, the </div> is for
div#wrap and needs to be moved outside of the form, rather than the form
moved inside the div.
In the case of the wp-admin/upload.php diff, the </div> should be removed;
it is the same issue -- closing div#wrap too early, which is closed later
again. If I had to guess, the floating clear is necessary inside the
</form>, but the one outside can be removed.
The wp-admin/edit-tags.php diff can be ignored. I can't find $location
used for anything beyond redirects, which should not have amp encoding.
(As it's a global, some other function might be pulling it in. Leaving it
alone.)
In the case of the wp-admin/includes/template.php diff, the ID addmetasub
is used only for styling. The addmeta name is, importantly, used in the
post handler. This change would break the form. I do not know what this is
trying to fix.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/15287#comment:6>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list