[wp-trac] [WordPress Trac] #15851: Admin Bar Is Not Properly Reset
WordPress Trac
wp-trac at lists.automattic.com
Sat Dec 18 21:26:23 UTC 2010
#15851: Admin Bar Is Not Properly Reset
-------------------------------------+-----------------------
Reporter: JohnONolan | Owner: ocean90
Type: defect (bug) | Status: assigned
Priority: high | Milestone: 3.1
Component: UI | Version: 3.1
Severity: normal | Resolution:
Keywords: has-patch needs-testing |
-------------------------------------+-----------------------
Comment (by filosofo):
Replying to [comment:21 pablox]:
> I believe when you design a wordpress theme you shouldn't keep in mind
if your styles affect or no the admin bar, makes way more sense that if
you want to affect it, preppend the #admin-bar (as JohnONolan said
before). I don't understand why a theme developer should have the admin
bar in mind, unless of course he wants to focus on it.
Is this a theme for WordPress? Then you should account for HTML elements
that are common in WordPress. In the past theme developers have had to
account for widget classes, more recently the menu classes, and now they
will have to handle admin bar classes. It's part of what it means to
develop themes for WordPress.
> Obviously we should have an equilibrium between "bloated" css and
simplifying the work for the theme designers, I believe that "reseting" a
propriety like in this case li :before { content: none; } is not that
we're bloating it.
You believe that the `:before` pseudo element should have global scope;
someone else believes that some other CSS rule should have global scope.
Where does it stop? That's what has to be decided, and I have suggested
common usage and a rough methodology for determining that usage, as the
criteria. All I'm arguing for is that we ''have'' a criterion or two,
rather than either trying to account for all scenarios or handling bugs as
they are reported.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/15851#comment:23>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list