[wp-trac] [WordPress Trac] #15353: Search box appears when there is nothing to search

WordPress Trac wp-trac at lists.automattic.com
Thu Dec 16 20:18:18 UTC 2010


#15353: Search box appears when there is nothing to search
-----------------------------------+-----------------------
 Reporter:  nacin                  |       Owner:  scribu
     Type:  defect (bug)           |      Status:  reopened
 Priority:  normal                 |   Milestone:  3.1
Component:  Administration         |     Version:  3.1
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |
-----------------------------------+-----------------------

Comment (by scribu):

 search_box.15353.diff adds a search_box() method to WP_List_Table, which
 is then reused in all list screens, except themes.php, due to the fancy
 new filter. :)

 Notes:

 In {{{network/users.php}}}, the submit_button() received 'post-query-
 submit', which was probably a bug. With the patch, it's 'submit'.

 In {{{edit.php}}} and {{{upload.php}}}, the_search_query() was used. In
 the patch, _admin_search_query() is used. I think this is ok, since most
 filters probably only want to hook into the front-end anyway.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/15353#comment:10>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list