[wp-trac] [WordPress Trac] #14867: HTTPS related issues in ms-blogs.php (with fix)
WordPress Trac
wp-trac at lists.automattic.com
Thu Dec 16 07:53:21 UTC 2010
#14867: HTTPS related issues in ms-blogs.php (with fix)
--------------------------+------------------
Reporter: mareck | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 3.1
Component: Multisite | Version:
Severity: normal | Resolution:
Keywords: has-patch |
--------------------------+------------------
Comment (by nacin):
This looks good. Notes:
1. No need for the UI option. The changes in site-info.php can be
entirely dropped I think.
2. Argument should be $scheme and should take 'https' and 'http' as valid
values, default null at which point we use is_ssl. This allows us to add
other protocols and it is also in line with functions in wp-includes/link-
template.php.
3. General whitespace. Looks good mostly, but `!isset($ssl)` should be `!
isset( $ssl )`.
Going to run with this. Thanks for the initial patch.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/14867#comment:8>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list