[wp-trac] [WordPress Trac] #15650: Inefficient selectors in common.dev.js

WordPress Trac wp-trac at lists.automattic.com
Sat Dec 11 20:06:02 UTC 2010


#15650: Inefficient selectors in common.dev.js
-------------------------+--------------------------------------------------
 Reporter:  GamajoTech   |       Owner:                
     Type:  enhancement  |      Status:  new           
 Priority:  normal       |   Milestone:  Future Release
Component:  Performance  |     Version:                
 Severity:  minor        |    Keywords:  needs-refresh 
-------------------------+--------------------------------------------------

Comment(by GamajoTech):

 Replying to [comment:3 nacin]:
 > A few of these make sense. But please see azaozz's comments.
 >
 > Also, we use tabs, not spaces. If you can correct the patch, it would be
 more readable.
 >
 > Optimizations like wpHasSubmenu aren't necessary, as it's only used once
 (referenced twice, but there's an if/else there).

 All noted. I'll re-do the patch.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/15650#comment:6>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list