[wp-trac] [WordPress Trac] #15729: Better UX after supplying incorrect information to setup-config

[WordPress Trac]

#15729: Better UX after supplying incorrect information to setup-config
-----------------------------+----------------------------------------------
 Reporter:  nacin            |       Owner:  kapeels                
     Type:  defect (bug)     |      Status:  accepted               
 Priority:  low              |   Milestone:  Future Release         
Component:  Upgrade/Install  |     Version:                         
 Severity:  normal           |    Keywords:  gci has-patch 3.2-early
-----------------------------+----------------------------------------------
Changes (by nacin):

  * keywords:  gci has-patch => gci has-patch 3.2-early


Comment:

 Last patch looks great. :-)

 Final feedback:
  - Not sure why display_header() was un-indented. It should be one indent
 inside of the case.
  - Rename the 'passwrd' varto 'password' or 'pwd'. It looks like a typo.
  - Initialize setup_error as a new WP_Error. Use ->add() inside the
 preg_match. Remove the setup_error == null check and make that into an
 else for the preg_match.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/15729#comment:7>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software