[wp-trac] [WordPress Trac] #15378: Post formats should have built-in index pages

WordPress Trac wp-trac at lists.automattic.com
Wed Dec 8 01:43:51 UTC 2010


#15378: Post formats should have built-in index pages
-------------------------+--------------------------------------------------
 Reporter:  nacin        |       Owner:           
     Type:  enhancement  |      Status:  new      
 Priority:  normal       |   Milestone:  3.1      
Component:  Themes       |     Version:  3.1      
 Severity:  normal       |    Keywords:  has-patch
-------------------------+--------------------------------------------------

Comment(by greenshady):

 Error with `_post_format_link()` when using the default permalink
 structure:

 {{{
 Warning: str_replace() expects at least 3 parameters, 2 given in
 C:\xampplite\htdocs\wp-includes\post.php on line 5173
 }}}

 This code is used `post.php`:

 {{{
 return add_query_arg( 'format', str_replace( 'post-format-', $term->slug
 ), $link );
 }}}

 `str_replace()` requires three parameters:

 {{{
 return add_query_arg( 'format', str_replace( 'post-format-', '',
 $term->slug ), $link );
 }}}

 Changing the code to that changes the term links to:
 `http://localhost/?post_format=post-format-aside&format=aside`.  I'm not
 sure if that's the desired result, so I didn't want to upload a patch yet.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/15378#comment:20>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list