[wp-trac] [WordPress Trac] #14729: Fatal errors after [15531] when conditional tags are used too early (was: Latest trunk breaks BuddyPress)

WordPress Trac wp-trac at lists.automattic.com
Mon Aug 30 03:51:31 UTC 2010


#14729: Fatal errors after [15531] when conditional tags are used too early
--------------------------+-------------------------------------------------
 Reporter:  zamoose       |       Owner:              
     Type:  defect (bug)  |      Status:  new         
 Priority:  normal        |   Milestone:  3.1         
Component:  General       |     Version:              
 Severity:  critical      |    Keywords:  dev-feedback
--------------------------+-------------------------------------------------
Changes (by nacin):

  * keywords:  buddypress => dev-feedback
  * milestone:  Awaiting Review => 3.1


Comment:

 The changes introduced in [15531] will generate fatal errors in plugins
 that have been incorrectly using the $wp_query object before it is
 properly initialized.

 I like the idea of leaving in fatal errors as then plugin developers know
 something is wrong -- we did so for register_taxonomy() with rewrite =
 true before init, although it wasn't a conscious decision to do so -- but
 because this change affects conditional tags, it'll likely break a good
 number of plugins and maybe themes.

 I have an interesting idea for this -- we leave this as is until late in
 the dev cycle. Hopefully that fixes up a good number of plugins including
 BuddyPress. And then we add sanity checks before release. Perhaps crazy,
 but at least it'll fix up a lot of code along the way.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/14729#comment:1>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list