[wp-trac] [WordPress Trac] #14671: Deprecate the "accepted args" argument in add_filter() and add_action()

WordPress Trac wp-trac at lists.automattic.com
Mon Aug 23 01:15:31 UTC 2010


#14671: Deprecate the "accepted args" argument in add_filter() and add_action()
-------------------------+--------------------------------------------------
 Reporter:  markjaquith  |       Owner:     
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  3.1
Component:  Plugins      |     Version:     
 Severity:  normal       |    Keywords:     
-------------------------+--------------------------------------------------

Comment(by jacobsantos):

 Removal of a feature will break backwards compatibility and will affect a
 small percentage of plugin / theme developers. Deprecating the argument
 using one of the built-in deprecate functions should be used first and
 then the code should be removed at a future date.

 Besides the reasoning you have in the summary, why would you want to
 remove the functionality?

 Several key points of contention:

  1. I don't think the removal of code is dependent of people who have
 never worked on the plugin system and most likely have no idea how it
 would affect those used to this feature you plan on removing. Honestly, I
 think the vote should be with those who have actually written a patch for
 the plugin system and have provided support in the past.
  1. Lets weight the pros and cons. What other reasons do you have for
 removing the feature?
  1. Saying a feature is useless, is a matter of opinion that is quite
 bluntly is useless. It is like saying something sucks. It is subjective,
 unproven and unprovable, and pointless. There are many features that are
 rarely used, like for example the blog-by-email. Lets remove that why
 don't we, oh wait that was tried and the few people that wanted it argued
 for keeping it.
  1. This code has been in !WordPress since the plugin API has been
 extended back in 1.2 to 1.5. Why break compatibility now?
  1. Have you done any statistics on which fraction of public plugins use
 the feature? We can put the guess at around .01% to 1%.
  1. Does this really affect beginners? In what way? I suppose you've
 handled the support, in what way were they confused with the feature. Is
 it something that inline documentation or Codex level documentation can
 correct in the future?

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/14671#comment:5>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list