[wp-trac] [WordPress Trac] #12564: comment_form() needs an output filter

WordPress Trac wp-trac at lists.automattic.com
Wed Apr 28 07:03:35 UTC 2010


#12564: comment_form() needs an output filter
------------------------------------+---------------------------------------
 Reporter:  joostdevalk             |        Owner:  joostdevalk
     Type:  enhancement             |       Status:  reopened   
 Priority:  normal                  |    Milestone:  3.0        
Component:  Comments                |      Version:             
 Severity:  normal                  |   Resolution:             
 Keywords:  has-patch dev-feedback  |  
------------------------------------+---------------------------------------
Changes (by westi):

  * status:  closed => reopened
  * resolution:  fixed =>


Comment:

 I'm not a big fan of output buffering in general and would rather we avoid
 it unless there is no other solution.

 Do we really need an output buffer here?

 The use case of this ticket can all be handled with either a specific
 'attribute' filter or just use JavaScript progressive enhancement to add
 it.

 I would rather revert this change.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/12564#comment:7>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list