[wp-trac] [WordPress Trac] #12832: Use the same data type for site statuses
WordPress Trac
wp-trac at lists.automattic.com
Wed Apr 28 06:50:31 UTC 2010
#12832: Use the same data type for site statuses
--------------------------+-------------------------------------------------
Reporter: ocean90 | Owner: database
Type: defect (bug) | Status: new
Priority: normal | Milestone: 3.0
Component: Multisite | Version: 3.0
Severity: normal | Keywords: needs-patch
--------------------------+-------------------------------------------------
Comment(by nacin):
Replying to [comment:6 wpmuguru]:
> Replying to [comment:4 nacin]:
> >
> > Is there a reason for install_network() to be pluggable? Or
specifically, for the table definitions to be pluggable?
>
> That was pluggable in MU. If someone wants to add columns to global
tables, the schemas have to be pluggable so that a dbDelta in a subsequent
upgrade doesn't drop the columns.
We didn't call it install_network() in MU though, they were simply part of
the global variable WP uses. I think we should add them back into that
variable, appending them conditionally. (And also appending global terms
conditionally.)
We should be able to make changes to $wp_queries and have it work. Right
now we have to call install_network() in an upgrade routine, which seems
odd. If someone wants to add columns, they'd tap into $wp_queries like the
rest, like how it was done in MU.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/12832#comment:7>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list