[wp-trac] [WordPress Trac] #12868: General Settings Page Needs Error Checking

[WordPress Trac]

#12868: General Settings Page Needs Error Checking
----------------------------+-----------------------------------------------
 Reporter:  Josh Jones      |       Owner:  technosailor         
     Type:  defect (bug)    |      Status:  accepted             
 Priority:  high            |   Milestone:  3.0                  
Component:  Administration  |     Version:  2.9.2                
 Severity:  major           |    Keywords:  has-patch ux-feedback
----------------------------+-----------------------------------------------
Changes (by dd32):

  * keywords:  error checking, blank value, has-patch, dev-feedback => has-
               patch ux-feedback


Comment:

 Had to change the patch slightly.
  * Changed the strings, Can I get some ux-feedback on the strings?
  * Had to rework the if branching, The patch did not protect against
 invalid url's at all, 'dubya dubya dubya' would result in a url of
 'http://dubyadubyadubya' thanks to esc_url() forcing it into a URL looking
 string
  * Removed is_url(), I feel that people might mistake its purpose, I'd
 also like to expand on the invalid url prevention in 3.1 to prevent URL's
 which do not load the Current WordPress instance. (Theres another ticket
 somewhere for this)

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/12868#comment:6>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software