[wp-trac] [WordPress Trac] #13107: Failure to load popular tags results in PHP errors in plugin-install.php

[WordPress Trac]

#13107: Failure to load popular tags results in PHP errors in plugin-install.php
----------------------------+-----------------------------------------------
 Reporter:  solarissmoke    |       Owner:     
     Type:  defect (bug)    |      Status:  new
 Priority:  normal          |   Milestone:  3.0
Component:  Administration  |     Version:  3.0
 Severity:  normal          |    Keywords:     
----------------------------+-----------------------------------------------
 Steps to reproduce:

 1. Block server access to Wordpress servers (simulating what happens when
 plugins_api() fails to connect to them)

 2. Visit plugins install page (wp-admin/plugin-install.php)

 Result:
 {{{
 Undefined index: name in \wplatest\wp-admin\includes\plugin-install.php on
 line 147
 Undefined index: name in \wplatest\wp-admin\includes\plugin-install.php on
 line 149
 etc etc..
 }}}

 I think the problem is on line 67 of plugin-install.php. If an error
 occurs, install_popular tags is returning a WP_Error object. But the
 calling function is expecting an array of tags, and doesn't check that the
 array is valid before attempting to walk it.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/13107>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software