[wp-trac] [WordPress Trac] #12307: files missing closing php tags
WordPress Trac
wp-trac at lists.automattic.com
Sat Apr 24 20:49:01 UTC 2010
#12307: files missing closing php tags
-------------------------------------------+--------------------------------
Reporter: washer | Owner: nacin
Type: defect (bug) | Status: accepted
Priority: lowest | Milestone: 3.1
Component: General | Version: 2.9.2
Severity: trivial | Resolution:
Keywords: has-patch needs-refresh early |
-------------------------------------------+--------------------------------
Changes (by nacin):
* keywords: has-patch => has-patch needs-refresh early
* milestone: 3.0 => 3.1
Comment:
Yeah, patch is stale anyway. I didn't bother applying, but since we
changed include paths, it'll bork.
> I vote we change the WP coding standard so that closing tags are not
included in any file.
I would tend to disagree with that. It identifies the end of the file so
you know the file is complete. The alternative would be to add {{{//
end}}}. It's a fine sanity check. We're normally pretty good about them,
so I'm surprised there's so many files missing them.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/12307#comment:12>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list