[wp-trac] [WordPress Trac] #13045: Login: Add Classes for better plugin-support and change from <p> to <div> for more flexibility

WordPress Trac wp-trac at lists.automattic.com
Fri Apr 23 15:31:02 UTC 2010


#13045: Login: Add Classes for better plugin-support and change from <p> to <div>
for more flexibility
----------------------------+-----------------------------------------------
 Reporter:  F J Kaiser      |       Owner:                          
     Type:  enhancement     |      Status:  new                     
 Priority:  normal          |   Milestone:  Unassigned              
Component:  Administration  |     Version:  2.9.2                   
 Severity:  minor           |    Keywords:  dev-feedback 2nd-opinion
----------------------------+-----------------------------------------------

Comment(by F J Kaiser):

 Hi nacin and markmcwilliams and thanks for the help & feedback. To make it
 easier to take a look at the changes, i added comments (search for
 "change") in the next "patch" (file taken from 3.0-nightly build). It's
 just to give you a faster & easier overview about the changes (i really
 can't login to svn. It works with wp.org and the plugin-rep, but not for
 core - sry 'bout this, i'll find out another day).

 In general i just try to unbind the admin-color-scheme from the login-page
 as described in the other ticket.

 In detail i just changed a) stop calling admin-color-scheme b) login
 messages. But nothing inside the <form>, so wp_login_form() won't be
 affected (no need for changes) by login.css or wp-login.php. When you're
 talking about semantic value then the provided patch should do it. If you
 think it's not, then i'd suggest to not house the error-messages in a
 paragraph, but an <ul>. (And yes, i was talking about child-block-elements
 added by f/ex a plugin-author or later wp-versions).

 My only *real* goal is to get rid of the admin-color-scheme and the
 id="login_error" (should be class in my humble opinion), because it makes
 things a little bit hard for plugin-authors or people who try to style the
 login in their theme. The other changes are just additions i thought that
 could be useful.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/13045#comment:7>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list