[wp-trac] [WordPress Trac] #12637: OS X-generated theme zips won't upload properly

[WordPress Trac]

#12637: OS X-generated theme zips won't upload properly
--------------------------+-------------------------------------------------
 Reporter:  chrisbliss18  |       Owner:  dd32     
     Type:  defect (bug)  |      Status:  accepted 
 Priority:  normal        |   Milestone:  3.0      
Component:  Filesystem    |     Version:  3.0      
 Severity:  normal        |    Keywords:  has-patch
--------------------------+-------------------------------------------------

Comment(by dd32):

 The __MAC_OSX annoyances are not a regression from a previous version. I
 feel that would be better dealt with by a better filepath parser/locator,
 There'll be some changes there in 3.1 most likely.. as multiple themes in
 uploaded zip's should be supposed

 As for ZIPARCHIVE::CHECKCONS, I'm still reluctant to remove that, as it'll
 mean other corrupt archives could slip through with it, or partially
 decompress.

 I do not have access to any form of Mac-based testbed, So i cant test
 directly here.

 chrisbliss18: What is the actual error that occurs when it attempts to
 open the zip file?

 For example, i'm using this code to test:
 {{{
 $zip = new ZipArchive;
 $open = $zip->open('C:/www/wordpress-commit/wordpress-commit.zip',
 ZIPARCHIVE::CHECKCONS);
 $open2 = $zip->open('C:/www/wordpress-commit/wordpress-commit.zip');

 //Results:
 $open = ZIPARCHIVE::ER_NOZIP - 19
 $open2 = (bool) true;
 }}}

 That zip archive is a 500KB archive with the 2nd half removed to simulate
 a incomplete archive. Thats the reason i dont want to remove the
 consistancy checking.

 At present, if ZipArchive fails to open the archive with
 ZIPARCHIVE::CHECKCONS set, it WILL fall through to using the previous
 methods, PclZip. This has been done in such a way, ZipArchive will only be
 used in the event that it can open the archive correctly - That has been
 the case since just after adding the ZipArchive support: [13221]

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/12637#comment:7>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software