[wp-trac] [WordPress Trac] #10910: Standardize comment form

WordPress Trac wp-trac at lists.automattic.com
Thu Apr 15 17:44:56 UTC 2010


#10910: Standardize comment form
----------------------------+-----------------------------------------------
 Reporter:  Otto42          |       Owner:  beaulebens
     Type:  task (blessed)  |      Status:  assigned  
 Priority:  normal          |   Milestone:  3.0       
Component:  Comments        |     Version:  2.9       
 Severity:  normal          |    Keywords:  has-patch 
----------------------------+-----------------------------------------------

Comment(by demetris):

 I attach a patch that fixes two potentially confusing typos in the phpDoc
 block, and also suggests renaming two action hooks:

 {{{
 comment_form_after_fields
 comment_form_before_fields
 }}}

 to:

 {{{
 comment_form_fields_after
 comment_form_fields_before
 }}}

 I think the suggested order is more logical.

 Another thing I don’t like in the comment form is the markup for the
 allowed HTML elements:  I think the Definition List is not the best choice
 here semantically, and it will also force people to use extra CSS to make
 that block look like one single paragraph, as it is most common in current
 usage.  (Twenty Ten does exactly this.)

 Why not go with the simplest option for the default?  (Which people can
 then change easily if they so wish.)  Something like:

 {{{
 '<p class="form-allowed-tags">
 .   __( 'You may use... blah blah...:' )
 .   '<code>' . allowed_tags() . '</code>'
 .   </p>
 }}}

 Other than these minor niggles, I really enjoyed playing with
 {{{comment_form}}}.  Thanks and congratulations to all who contributed!

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/10910#comment:38>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list